client/shell: Start instance if it's not running #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerboland
suggested changes
Feb 27, 2019
|
Regarding tests, yeah, we need to do a bunch of work in these types of places to enable testing, ie, mocking many things, etc. It's something we really, really need to do, but this is not the place to do it. |
|
Re: tests, ok |
townsend2010
force-pushed
the
shell-start-instance
branch
from
b25f06d to
f9b67f3
Compare
Also, use original message when instance is not running. Based on review feedback
townsend2010
force-pushed
the
shell-start-instance
branch
from
f9b67f3 to
331dcd1
Compare
|
@gerboland, this is ready for another review pass. Thanks! |
gerboland
approved these changes
Feb 28, 2019
bors bot
added a commit
that referenced
this pull request
Feb 28, 2019
631: client/shell: Start instance if it's not running r=gerboland a=townsend2010 Fixes #621 Co-authored-by: Chris Townsend <[email protected]>
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621