Remove sshfs install from cloud-init #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
townsend2010
force-pushed
the
remove-sshfs-cloud-init
branch
2 times, most recently
from
f494c36 to
fb6ace1
Compare
|
@townsend2010 this needs a conflict resolve |
added 3 commits
February 28, 2019 09:27
This will no longer do 'apt update' and install 'sshfs' inside the instance during cloud-init and thus, will speed up 'launch'. Fixes #615
The client (and user) no longer need to wait for cloud-init to finish in the instance since cloud-init no longer installs sshfs.
townsend2010
force-pushed
the
remove-sshfs-cloud-init
branch
from
fb6ace1 to
ea5d56b
Compare
|
Ok, merge conflict resolved and is ready for review:) |
|
bors try |
tryBuild failed |
ricab
requested changes
Mar 1, 2019
ricab
approved these changes
Mar 1, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 1, 2019
619: Remove sshfs install from cloud-init r=ricab a=townsend2010 Also move "just in time" sshfs install logic into the daemon. Fixes #615 Co-authored-by: Chris Townsend <[email protected]>
Build failed |
|
It seems the method removal needs to be propagated to hyperkit: https://travis-ci.org/CanonicalLtd/multipass/jobs/500462368#L3975 I suppose the windows one too? |
|
Yes, that occurs when we merge |
|
@townsend2010 delegating as I am not sure what's best in face of bors failing. bors delegate=townsend2010 |
|
✌️ townsend2010 can now approve this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move "just in time" sshfs install logic into the daemon.
Fixes #615