Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daemon hangs when suspending a suspended instance. #561

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fix daemon hangs when suspending a suspended instance. #561

merged 1 commit into from
Jan 16, 2019

Conversation

smokfyz
Copy link
Contributor

@smokfyz smokfyz commented Jan 16, 2019 •
edited
Loading

Fix #559 and also hangs when suspending a stopped instance.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #561 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   66.04%   66.03%   -0.02%     
==========================================
  Files         146      146              
  Lines        5716     5717       +1     
==========================================
  Hits         3775     3775              
- Misses       1941     1942       +1
Impacted Files Coverage Δ
...rc/platform/backends/qemu/qemu_virtual_machine.cpp 63.76% <0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ed010...a9529e4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #561 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   66.04%   66.03%   -0.02%     
==========================================
  Files         146      146              
  Lines        5716     5717       +1     
==========================================
  Hits         3775     3775              
- Misses       1941     1942       +1
Impacted Files Coverage Δ
...rc/platform/backends/qemu/qemu_virtual_machine.cpp 63.76% <0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ed010...a9529e4. Read the comment docs.

@Saviq
Copy link
Collaborator

Saviq commented Jan 16, 2019

bors try

bors bot added a commit that referenced this pull request Jan 16, 2019
@bors
Try #561:
ad86f44
@bors
Copy link
Contributor

bors bot commented Jan 16, 2019

try

Build failed

townsend2010
townsend2010 approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! +1

bors r+

bors bot added a commit that referenced this pull request Jan 16, 2019
@bors @smokfyz
Merge #561
4bd6a58 
561: Fix daemon hangs when suspending a suspended instance. r=townsend2010 a=smokfyz

Fix #559 and also hangs when suspending a stopped instance.

Co-authored-by: Ivan Sharapenkov <[email protected]>
@smokfyz
Copy link
Contributor Author

smokfyz commented Jan 16, 2019

@townsend2010, I noticed that during the build the time limit was exceeded. Does it have something to do with my changes?

@townsend2010
Copy link
Contributor

@smokfyz, no, it's just sometimes Travis is slow, so a retry should get it. I'll keep on top of it to make sure it gets merged. Thanks!

@bors
Copy link
Contributor

bors bot commented Jan 16, 2019

Build succeeded

@bors bors bot merged commit a9529e4 into canonical:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@townsend2010 townsend2010 townsend2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smokfyz @Saviq @townsend2010