Fix segfault in aliases command
#3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the alias dictionary is correctly printed in case there exists an empty context.
The table formatter did not consider the case on which existed an empty context. It tried to iterate over a nonexisting dictionary.
luis4a0
force-pushed
the
fix-aliases-segfault
branch
from
f2472dc to
a1b6a44
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3384 +/- ##
==========================================
- Coverage 84.18% 84.18% -0.01%
==========================================
Files 251 251
Lines 13816 13820 +4
==========================================
+ Hits 11631 11634 +3
- Misses 2185 2186 +1 ☔ View full report in Codecov by Sentry. |
|
Hey @andrei-toterman! Could you please review this soon? Thanks! |
andrei-toterman
approved these changes
Jan 26, 2024
townsend2010
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix segfault in `aliases` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the alias dictionary contained an empty context, the table formatter segfaulted.
Fixes #3383.