Release 1.1.0 #1375

Saviq · 2020-02-20T17:59:15Z

Diff from master: https://paste.ubuntu.com/p/3P4BKf9q44/

1353: output: Use qUtf8Printable() instead of qPrintable() r=Saviq a=townsend2010 This is supposed to be used for logging and will also help with proper UTF8 output on Windows. Co-authored-by: Chris Townsend <[email protected]>

1155: [travis] fix release handling r=ricab a=Saviq We incorrectly published on PRs of `release/0.9` branches, and the version determination required for `release/*` to be a local ref instead of one in the `origin` remote. Co-authored-by: Michał Sawicz <[email protected]> Co-authored-by: Ricardo Abreu <[email protected]>

codecov · 2020-02-20T19:06:03Z

Codecov Report

Merging #1375 into master will increase coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage    73.2%   73.22%   +0.01%     
==========================================
  Files         208      208              
  Lines        7547     7545       -2     
==========================================
  Hits         5525     5525              
+ Misses       2022     2020       -2

Impacted Files	Coverage Δ
src/platform/console/unix_console.h	`0% <ø> (ø)`	⬆️
...orm/backends/qemu/qemu_virtual_machine_factory.cpp	`74.15% <0%> (-0.85%)`	⬇️
src/platform/console/unix_console.cpp	`0% <0%> (-2.64%)`	⬇️
src/client/cli/cmd/get.cpp	`88.46% <100%> (ø)`	⬆️
...c/platform/backends/shared/linux/backend_utils.cpp	`66.66% <100%> (ø)`	⬆️
src/client/cli/cmd/help.cpp	`93.1% <100%> (ø)`	⬆️
src/platform/backends/shared/basic_process.cpp	`78.04% <50%> (ø)`	⬆️
src/platform/update/new_release_monitor.cpp	`82.14% <50%> (-1.2%)`	⬇️
src/client/cli/argparser.cpp	`85.31% <57.14%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf50253...47d43f1. Read the comment docs.

ricab · 2020-02-20T19:20:52Z

@Saviq Would you cherry-pick the new commit into master?

Maybe we can have Travis test this but then get it in a regular PR, merged into master, and cherry-pick that into the release branch, as usual? If it is still just a small change and Travis does the right thing here, send it my way and I'll approve when I see it (=tomorrow).

1377: [cmake] use a CMake variable for MULTIPASS_UPSTREAM r=ricab a=Saviq Rather than reading straight from the environment. Co-authored-by: Michał Sawicz <[email protected]>

1354: unix_console: Better handle SIGWINCH r=Saviq a=townsend2010 On OSX, SIGWINCH is ignored by default and thus, the way the console code was waiting on the signal, it was never being delivered and the console size would never change. Since OSX and Linux handle the console code the same, this change is for both platforms. Fixes #1327 Co-authored-by: Chris Townsend <[email protected]>

1382: [logging] add trace level (Fixes #1371) r=townsend2010 a=Saviq Move AppArmor profile logging contents to the trace level to avoid spamming the logs. Co-authored-by: Michał Sawicz <[email protected]> Co-authored-by: Michał Sawicz <[email protected]>

codecov · 2020-02-25T16:43:52Z

Codecov Report

Merging #1375 into master will increase coverage by 0.03%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage    73.2%   73.24%   +0.03%     
==========================================
  Files         208      208              
  Lines        7547     7546       -1     
==========================================
+ Hits         5525     5527       +2     
+ Misses       2022     2019       -3

Impacted Files	Coverage Δ
src/platform/console/unix_console.h	`0% <ø> (ø)`	⬆️
...rc/platform/backends/qemu/qemu_virtual_machine.cpp	`68.96% <0%> (ø)`	⬆️
...tform/backends/libvirt/libvirt_virtual_machine.cpp	`69% <0%> (ø)`	⬆️
src/platform/logger/journald_logger.cpp	`0% <0%> (ø)`	⬆️
src/utils/settings.cpp	`18.42% <0%> (ø)`	⬆️
src/platform/console/unix_console.cpp	`0% <0%> (-2.64%)`	⬇️
...orm/backends/qemu/qemu_virtual_machine_factory.cpp	`74.15% <0%> (-0.85%)`	⬇️
include/multipass/process.h	`100% <100%> (ø)`	⬆️
src/client/cli/cmd/get.cpp	`88.46% <100%> (ø)`	⬆️
src/platform/backends/shared/linux/apparmor.cpp	`63.82% <100%> (ø)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf50253...4475d34. Read the comment docs.

townsend2010 · 2020-02-25T20:16:05Z

I tested the Mac package and all seems well. That said, as mentioned on IRC, I'd like to set a new minimum OSX version. Since we build on a 10.13 machine, I thought we should set the minimum version to that. However, #1258 (comment) seems to indicate that 10.14 is the minimum, but it is not clear to me where that comes from.

townsend2010 · 2020-02-25T20:56:52Z

As an aside, I tried snap refresh multipass --channel candidate/1.1 per the instructions above and I get:

error: requested a non-existing branch on latest/candidate for snap "multipass": 1.1

marcodelapierre · 2020-02-26T02:52:01Z

Just tested the rc on a mac, to test for a terminal resizing issue I had with 1.0.
The release candidate has fixed my issue.
(see also my comment in #1370 )

Saviq · 2020-02-26T08:17:34Z

error: requested a non-existing branch on latest/candidate for snap "multipass": 1.1

Fixed: 79004a6

Saviq · 2020-02-26T11:45:45Z

I've tested all of the v1.1.0 milestone on Linux (and the other platforms, where the issue was platform-specific) and confirmed it all worked, didn't see any new issues.

Refreshing from stable to candidate/1.1 also works, recovering instance state.

1394: [backends] throw, don't just return the exceptions on IP timeout r=townsend2010 a=Saviq Co-authored-by: Michał Sawicz <[email protected]>

1392: [general] compatibility with macOS's c++17 support r=ricab a=Saviq To keep our minimal macOS version lower, we need to work around some limitations of their c++17 support. What we know so far: - `std::optional::value()` and `::reset()` are not supported - `std::bad_optional_access` has no d'tor (so we mustn't throw it manually either) - `std::optional::emplace` non-conformant (returns `void` rather than `T&`) - `std::scoped_lock` is not supported - `std::lock_guard` needs to be templated Fixes #1258 Co-authored-by: Michał Sawicz <[email protected]> Co-authored-by: Michał Sawicz <[email protected]>

NickZ · 2020-03-01T04:21:44Z

Issue #1170 is still present in the above Windows build: #1170 (comment)

1401: console/unix: Only set terminal attributes when stdin & stdout are live r=Saviq a=townsend2010 Fixes #1310 Co-authored-by: Chris Townsend <[email protected]>

multipass-ci-bot · 2020-03-04T11:17:39Z

Snap build available: snap refresh multipass --channel candidate/1.1

townsend2010

Yeps

bors bot and others added 2 commits February 20, 2020 18:58

Merge #1353

642b44f

1353: output: Use qUtf8Printable() instead of qPrintable() r=Saviq a=townsend2010 This is supposed to be used for logging and will also help with proper UTF8 output on Windows. Co-authored-by: Chris Townsend <[email protected]>