Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete for multipass mount should not provide deleted instances #700

Closed
ricab opened this issue Mar 29, 2019 · 0 comments · Fixed by #788
Closed

Autocomplete for multipass mount should not provide deleted instances #700

ricab opened this issue Mar 29, 2019 · 0 comments · Fixed by #788
Assignees
@townsend2010
Labels
bug good first issue help wanted

Comments

@ricab
Copy link
Collaborator

ricab commented Mar 29, 2019

For instance, allowed-marsupial was auto-completed below:

$ multipass list
Name                    State             IPv4             Release
allowed-marsupial       DELETED           --               Not Available
$ multipass mount ~/tmp/ allowed-marsupial
mount failed: The following errors occurred:
instance "allowed-marsupial" does not exist
@townsend2010 townsend2010 self-assigned this May 16, 2019
townsend2010 pushed a commit that referenced this issue May 16, 2019
completions: Do not allow mount to autocomplete deleted instances
f3bee27 
Fixes #700
@townsend2010 townsend2010 mentioned this issue May 16, 2019
Merged
bors bot added a commit that referenced this issue May 17, 2019
@bors
Merge #788
e7ba2dd 
788: Fix various autocomplete bugs r=gerboland a=townsend2010

Fixes #700, fixes #714, fixes #716 

Co-authored-by: Chris Townsend <[email protected]>
bors bot added a commit that referenced this issue May 17, 2019
@bors
Merge #788
8782201 
788: Fix various autocomplete bugs r=gerboland a=townsend2010

Fixes #700, fixes #714, fixes #716 

Co-authored-by: Chris Townsend <[email protected]>
@bors bors bot closed this as completed in #788 May 17, 2019
Saviq pushed a commit that referenced this issue May 28, 2019
@bors @Saviq
Merge #788
5a0e0c8 
788: Fix various autocomplete bugs r=gerboland a=townsend2010

Fixes #700, fixes #714, fixes #716 

Co-authored-by: Chris Townsend <[email protected]>
Saviq pushed a commit that referenced this issue May 28, 2019
@bors @Saviq
Merge #788
ba8e740 
788: Fix various autocomplete bugs r=gerboland a=townsend2010

Fixes #700, fixes #714, fixes #716 

Co-authored-by: Chris Townsend <[email protected]>
Saviq pushed a commit that referenced this issue May 28, 2019
@bors @Saviq
Merge #788
46190b0 
788: Fix various autocomplete bugs r=gerboland a=townsend2010

Fixes #700, fixes #714, fixes #716 

Co-authored-by: Chris Townsend <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@townsend2010 townsend2010

Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix various autocomplete bugs canonical/multipass
3 participants
@Saviq @ricab @townsend2010