-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to preprocess RAM / disk size request between daemon and hypervisors #616
Labels
Comments
ricab
added a commit
that referenced
this issue
Feb 22, 2019
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab
added a commit
that referenced
this issue
Feb 26, 2019
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab
added a commit
that referenced
this issue
Feb 28, 2019
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab
added a commit
that referenced
this issue
Mar 1, 2019
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab
added a commit
that referenced
this issue
Mar 8, 2019
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
This wasn't automatically closed for some reason. Closing manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today we pass the memory / disk size requests verbatim to the hypervisor backends, meaning they all need to deal themselves with
[KMG]?B?
suffixes.We should instead ensure the value is sanitized and unified before handing it off to the backends so they only need to deal with preparing it for the hypervisor in question.
The text was updated successfully, but these errors were encountered: