Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not validate memory size #588

Closed
carmine opened this issue Feb 3, 2019 · 3 comments
Closed

Does not validate memory size #588

carmine opened this issue Feb 3, 2019 · 3 comments
Assignees
Labels

Comments

@carmine
Copy link

carmine commented Feb 3, 2019

I'm trying to launch an instance with the memory specified. When forgetting to specify the quantity of memory, you get the error above. It'd be good to provide a check and print a message.

Here's an example:

| => multipass launch bionic -n fred -c 4 -m 1
Starting openkilda \[2019-02-04T00:42:27.811] [error] [fred] mptable requires mapped mem

Of course, the issue is that I specified 1 byte for memory :-) .. so maybe check that at least X bytes is specified?

@carmine
Copy link
Author

carmine commented Feb 3, 2019

Also, whereas you can delete the VM, when you try to purge, I get this message

 => multipass purge
purge failed: cannot connect to the multipass socket
Please ensure multipassd is running and '/var/run/multipass_socket' is accessible

This seems to only happen when using a dodgy -m size.

@Saviq
Copy link
Collaborator

Saviq commented Feb 4, 2019

That second one is multipassd crashing when purging a broken instance: #585 - agreed we should validate the memory input :)

@Saviq Saviq added the bug label Feb 4, 2019
@Saviq Saviq changed the title [error] [fred] mptable requires mapped mem Does not validate memory size Feb 4, 2019
@ricab ricab self-assigned this Feb 21, 2019
ricab added a commit that referenced this issue Feb 26, 2019
Makes failing tests pass. Fixes #588.
ricab added a commit that referenced this issue Feb 28, 2019
Makes failing tests pass. Fixes #588.
ricab added a commit that referenced this issue Mar 1, 2019
Makes failing tests pass. Fixes #588.
ricab added a commit that referenced this issue Mar 8, 2019
Makes failing tests pass. Fixes #588.
@ricab
Copy link
Collaborator

ricab commented Mar 13, 2019

This wasn't automatically closed for some reason. Closing manually.

@ricab ricab closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants