Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress metrics error message #486

Closed
carmine opened this issue Nov 11, 2018 · 8 comments
Closed

Suppress metrics error message #486

carmine opened this issue Nov 11, 2018 · 8 comments

Comments

@carmine
Copy link

carmine commented Nov 11, 2018

When launching a VM I got the following error message; feels like this should be suppressed.

Starting .. -[2018-11-11T17:16:14.537] [error] [metrics] Metrics error: Error transferring https://api.staging.jujucharms.com/omnibus/v4/multipass/metrics - server replied: Proxy Error - Attempting to resend

@gerboland gerboland added the bug label Nov 12, 2018
@gerboland
Copy link
Contributor

Are you behind a proxy?

@Saviq
Copy link
Collaborator

Saviq commented Nov 12, 2018

Any case, we should probably reduce the severity of those messages to warnings.

@carmine
Copy link
Author

carmine commented Nov 18, 2018

Wasn't behind a proxy, but I may have experienced intermittent networking issues. The error message seemed orthogonal to what I was doing (ie launching a VM) - or at least not critical to the requested operation.

If these metrics are just nice-to-have, then a warning in a log file should suffice. If the desire to collect is stronger than that, then caching the data and sending at some other time may be appropriate.

@Saviq
Copy link
Collaborator

Saviq commented Nov 18, 2018

Yeah that last part definitely happens, which is why Attempting to resend - completely agree it should not be surfaced to the user at the error (or even warning?) level.

@townsend2010 townsend2010 self-assigned this Dec 7, 2018
townsend2010 pushed a commit that referenced this issue Dec 7, 2018
This will keep messages from bubbling up to the client unless '-vv' or greater is used.

Fixes #486
bors bot added a commit that referenced this issue Dec 7, 2018
515: metrics_provider: Use 'info' logging level for metrics issues r=Saviq a=townsend2010

This will keep messages from bubbling up to the client unless '-vv' or greater is used.

Fixes #486

Co-authored-by: Chris Townsend <[email protected]>
@bors bors bot closed this as completed in #515 Dec 7, 2018
@Saviq Saviq added this to the 2018.12.1 milestone Dec 14, 2018
@brlin-tw
Copy link

I still see metric errors in the system journal of edge multipass:

Metrics error: Error transferring https://api.staging.jujucharms.com/omnibus/v4/multipass/metrics - server replied: Internal Server Error - Attempting to resend

It appears that multipassd is run with the --verbosity debug flag on.

@Saviq
Copy link
Collaborator

Saviq commented Mar 17, 2019

Yes, it is on purpose to log to journal with debug verbosity, this way we get enhanced history in case of issues.

When looking at the log, you can use the --priority switch and note the text formatting/colouring to see what messages are more important.

@brlin-tw
Copy link

When looking at the log, you can use the --priority switch and note the text formatting/colouring to see what messages are more important.

Is there any way to customize it and make the change survive after snap refresh?

@Saviq
Copy link
Collaborator

Saviq commented Mar 17, 2019

What change? The --priority switch to journalctl? It only affects the display, not what is actually logged. Why would you want to change that?

I noticed we don't pass $@ to multipassd in our launcher. Please file an issue about that, it would then allow you to tweak the options with systemctl edit snap.multipass.multipassd.service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants