Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] Wrong owner/group used when making new directory in a mount #2553

Closed
townsend2010 opened this issue May 5, 2022 · 0 comments · Fixed by #2556
Closed

[regression] Wrong owner/group used when making new directory in a mount #2553

townsend2010 opened this issue May 5, 2022 · 0 comments · Fixed by #2556
Assignees
@luis4a0
Labels
bug high high importance

Comments

@townsend2010
Copy link
Contributor

On 1.9.0, making a new directory in a mount gives it root/root ownership instead of ubuntu/ubuntu. This also translates to root/root ownership on the host.
@townsend2010 townsend2010 added bug high high importance labels May 5, 2022
@luis4a0 luis4a0 self-assigned this May 5, 2022
@luis4a0 luis4a0 mentioned this issue May 5, 2022
Merged
@bors bors bot closed this as completed in fa5bd77 May 11, 2022
townsend2010 pushed a commit that referenced this issue May 12, 2022
@bors @luis4a0
Merge #2556
74d500e 
2556: Fix ownership of a folder created under a mount r=townsend2010 a=luis4a0

The reverse id mapping function returned `-1` if the current user was not found on the reverse mappings. Since the folder is created as root, when `0` did not exist in the reverse mappings the new folder retained the `0` id, because `-1` makes `chown` to keep the owner.

We use now the user/groups id's of the parent folder if the current user is not found on the reverse mappings. This was the behavior before implementing reverse id mapping.

Fixes #2553.

Co-authored-by: Luis Peñaranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luis4a0 luis4a0

Labels
bug high high importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ownership of a folder created under a mount canonical/multipass
2 participants
@luis4a0 @townsend2010