Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check docs links using Playwright MAASENG-4310 #5586

Merged
merged 11 commits into from
Feb 6, 2025

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jan 21, 2025

Done

  • Re-wrote the docs links checker in Playwright, as cy.visit() is notoriously flakey
  • Updated non-functioning docs links to point to correct pages:
    • Add machines
    • Set up MAAS in the UI
    • DHCP
    • Configure controllers
    • Build windows images
    • IP ranges
    • Automatic tags
    • Kernel options in tags
    • XPaths expressions

QA steps

Fixes

Resolves MAASENG-4310

@webteam-app
Copy link

@ndv99
Copy link
Contributor Author

ndv99 commented Jan 21, 2025

@billwear Might need your help with some of these dead links and getting a suitable replacement sorted

@ndv99 ndv99 marked this pull request as ready for review February 6, 2025 09:01
@ndv99 ndv99 changed the title docs: update links to MAAS documentation MAASENG-4310 ci: Check docs links using Playwright MAASENG-4310 Feb 6, 2025
@ndv99 ndv99 requested a review from abuyukyi101198 February 6, 2025 12:29
Copy link
Contributor

@abuyukyi101198 abuyukyi101198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ndv99 ndv99 enabled auto-merge (squash) February 6, 2025 12:34
@ndv99 ndv99 merged commit d508535 into canonical:main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants