Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(machines): Allow sorting by disks and storage (3.6 backport) #5578

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(machines): Allow sorting by disks and storage (3.6 backport) #5578

merged 1 commit into from
Jan 14, 2025

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jan 13, 2025

Done

  • Added total_storage and physical_disk_count as valid fetch group keys
  • Added onClick handlers to disks and storage column headers to update the sort key

Fixes

Resolves LP#2092299

@ndv99 ndv99 requested a review from tmerten January 13, 2025 16:23
@webteam-app
Copy link

Demo

Jenkins

demos.haus

tmerten
tmerten approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ndv99 ndv99 merged commit 3f4c30e into canonical:3.6 Jan 14, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmerten tmerten tmerten approved these changes

Assignees
No one assigned
Labels
Backport 3.6 ◀️ Review: Code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @tmerten