Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kvm): KVM CPU resources label positioning MAASENG-2381 #5348

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(kvm): KVM CPU resources label positioning MAASENG-2381 #5348

merged 2 commits into from
Mar 14, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Mar 14, 2024 •
edited by Jay-Topher
Loading

Done

  • Fixed positioning of "CPU Cores" text in KVM resources cards

QA steps

  • Go to kvm list and click a host
  • Shrink your window width to < 1300px
  • Ensure that "CPU Cores" is displayed above the meter key (the text that says "Allocated")

Fixes

Fixes MAASENG-2381

Screenshots

Before

image

After

image

@webteam-app
Copy link

Demo starting at https://maas-ui-5348.demos.haus

Jay-Topher
Jay-Topher approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ndv99 ndv99 merged commit 7840a85 into canonical:main Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

@petermakowski petermakowski Awaiting requested review from petermakowski

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @Jay-Topher