feat: move network discovery forms to sidepanel #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://maas-ui-5285.demos.haus |
|
QA looks good, just make sure to fix that linting issue |
Jay-Topher
force-pushed
the
MAASENG-2572-move-network-discovery-sidepanel
branch
from
e66ecb5 to
dbd390a
Compare
|
@ndv99, fixed. Please have a look |
ndv99
approved these changes
Jan 16, 2024
ndv99
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA steps
/network-discoveryFixes
Fixes: Move Network Discovery forms to side panel
Screenshots
###. Before
After
Notes