feat: add grafana_base_url to Grafana source #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Loki needs to know the Grafana base URL for its

ruler
config which may have an ingress. This is needed to correctly render the Source button URL to Grafana when Loki alert rules are firing:Solution
Is this relation the best way to give Loki the ingress URL from Grafana? It makes sense since this scenario requires the
grafana-source
relation, otherwise Loki logs won't make it to Grafana and this scenario won't be possible.Context
Testing Instructions
juju refresh
both charms with the packed charmsUpgrade Notes
.