[DPE-5079]: Kyuubi HA with kyuubi <> zookeeper integration #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoctober19th
changed the title
theoctober19th
commented
Aug 24, 2024
theoctober19th
commented
Aug 24, 2024
theoctober19th
requested review from
welpaolo,
deusebio,
marcoppenheimer and
zmraul
deusebio
approved these changes
Aug 26, 2024
|
@deusebio Thanks a lot for the review! I agree with your points. Since we're going to merge this to the feature/kyuubi-ha branch, I'd rather piggyback these non-blocking suggestions in the next PR I open in the same feature (that way, the CI need not be triggered again). At the end, these will appear in I'm waiting for @welpaolo's review here and once I have that, I'll merge this and push your suggestions in the next PR in the same feature/epic. |
welpaolo
approved these changes
Aug 27, 2024
welpaolo
approved these changes
Aug 27, 2024
|
I'm merging this now to |
theoctober19th
added a commit
that referenced
this pull request
Sep 24, 2024
deusebio
pushed a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that the base branch is
feature/kyuubi-ha. This is because I wanted to have full HA working in thefeature/kyuubi-habranch before we merge it tomainand release it. All other subsequent works on Kyuubi HA will be merged tofeature/kyuubi-haand at the end, this feature branch will be merged tozookeeper-integration.