Improve queries after LogStructured removal #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #194 |
BenchmarkResultsCurrent status |
marco6
force-pushed
the
KU-1750/better-get-queries-after-merge
branch
from
8309551 to
1d65a6e
Compare
marco6
changed the title
marco6
force-pushed
the
KU-1750/better-get-queries-after-merge
branch
from
1d65a6e to
26ae39e
Compare
marco6
force-pushed
the
KU-1750/better-get-queries-after-merge
branch
from
26ae39e to
47e6f72
Compare
marco6
force-pushed
the
KU-1750/better-get-queries-after-merge
branch
from
47e6f72 to
9552496
Compare
|
Marking as ready as #194 was merged. |
louiseschmidtgen
approved these changes
Nov 27, 2024
| @@ -42,7 +42,8 @@ func init() { | |||
| } | |||
|
|
|||
| type Dialect interface { | |||
| List(ctx context.Context, prefix, startKey string, limit, revision int64, includeDeleted bool) (*sql.Rows, error) | |||
| List(ctx context.Context, prefix, startKey string, limit, revision int64) (*sql.Rows, error) | |||
| ListTTL(ctx context.Context, revision int64) (*sql.Rows, error) | |||
There was a problem hiding this comment.
I love this as a separate function on the dialect, it not only makes the queries more readable but also reduces the amount of things we return.
There was a problem hiding this comment.
This also reflects nicely in the benchmark :) Thanks!
petrutlucian94
added a commit
that referenced
this pull request
Feb 5, 2025
This reverts commit 40bd618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage from the reduced need of SQLLog after the merge LogStructured. This should result in a smoother startup and less data passed through the network.