Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Create a separate snapctl package #26

Merged
merged 18 commits into from
Mar 8, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jan 20, 2022

To Do:

  • get
  • set
  • unset
  • start
  • stop
  • services
  • restart

@farshidtz farshidtz marked this pull request as ready for review February 23, 2022 12:19
@farshidtz
Copy link
Member Author

Let's review and get this merged to have the testing environment and the new function for use by other parallel work. The remaining tasks can be done in separate PRs.

@farshidtz
Copy link
Member Author

@siggiskulason I've added the set functions.

@farshidtz
Copy link
Member Author

@siggiskulason I've implemented the services functions needed for the new config options API.

Copy link
Contributor

@siggiskulason siggiskulason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested this according to the instructions and everything ran as expected. The code looks good as well, but as this is still a work in progress I won't do a code review until it's all done.

@farshidtz farshidtz merged commit e9c2f94 into canonical:master Mar 8, 2022
@farshidtz farshidtz deleted the snapctl-package branch March 8, 2022 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants