Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure fqdn is always treated as a string in get_hostname_fqdn #5993

Merged

Conversation

masihkhatibzadeh99
Copy link
Contributor

Fixes #5989

Fix

  • Explicitly cast fqdn to a string before processing.

@TheRealFalcon TheRealFalcon self-assigned this Feb 7, 2025
@TheRealFalcon TheRealFalcon added the CLA signed The submitter of the PR has signed the CLA label Feb 7, 2025
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution!

@TheRealFalcon TheRealFalcon merged commit b45d66a into canonical:main Feb 7, 2025
22 checks passed
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
…#5993)

Explicitly cast fqdn to a string before processing.

Fixes canonicalGH-5989

Co-authored-by: masih.khatibzdeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If FQDN is number, cloud-config.service fails
2 participants