Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test robustness and simplify debugging ephemeral failures #5901

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Nov 25, 2024

Additional Context

One commit makes tests more robust to platform failure.
The other makes it straightforward to debug ephemeral failures.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Retry when instance restart fails. Throw exception if too many failures occur.
Retry when instance destory fails. Log error if too many failures occur.
@holmanb holmanb force-pushed the holmanb/test-robustness branch from 8801491 to 9f8ed0b Compare November 25, 2024 21:58
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! I left some inline comments.

tests/integration_tests/conftest.py Outdated Show resolved Hide resolved
tests/integration_tests/conftest.py Show resolved Hide resolved
tests/integration_tests/instances.py Show resolved Hide resolved
@TheRealFalcon TheRealFalcon self-assigned this Nov 26, 2024
@holmanb holmanb marked this pull request as draft December 14, 2024 02:16
Copy link

github-actions bot commented Jan 7, 2025

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Jan 7, 2025
@github-actions github-actions bot closed this Jan 15, 2025
@holmanb holmanb reopened this Jan 15, 2025
@github-actions github-actions bot removed the stale-pr Pull request is stale; will be auto-closed soon label Jan 16, 2025
Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Jan 31, 2025
@github-actions github-actions bot removed the stale-pr Pull request is stale; will be auto-closed soon label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants