fix(actions): doc labeler needs all clause instead of default any #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unspecified base match in labeler assumes 'any' for each match clause. When specifying base-branch and --any-glob-to-any-file either one of these cases would result in a successful match which would label all PRs again main as documentation. We need to explicitly specify 'all:' in our labeler match config to ensure BOTH - matching file paths related to documentation -AND- - targeting a merge against 'main' branch
github-actions
bot
added
the
documentation
blackboxsw
added
documentation
|
Adding documentation label here as this is a docs-related fix |
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Aug 2, 2024
…nonical#5568) Unspecified base match in labeler assumes 'any' for each match clause. When specifying base-branch and --any-glob-to-any-file either one of these cases would result in a successful match which would label all PRs again main as documentation. We need to explicitly specify 'all:' in our labeler match config to ensure BOTH: * matching file paths related to documentation -AND- * targeting a merge against 'main' branch
holmanb
pushed a commit
that referenced
this pull request
Aug 6, 2024
) Unspecified base match in labeler assumes 'any' for each match clause. When specifying base-branch and --any-glob-to-any-file either one of these cases would result in a successful match which would label all PRs again main as documentation. We need to explicitly specify 'all:' in our labeler match config to ensure BOTH: * matching file paths related to documentation -AND- * targeting a merge against 'main' branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
labeler github action appears to have when being triggered by 'old' repo .github/workflow state which results in this PR's documentation label being added. To test this without concern for interaction with prior .github/workflow state, I was able to change the
documentation:label in .github/labeler.yml to some other labelinvalid:and put up a pull request again my local repo'smainto ensure invalid was only added when my PR also included a change to cloudinit/config/schemas/schema-cloud-config-v1.json.Merge type