-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc-spelling fixes #5547
Merged
Merged
doc-spelling fixes #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-makin
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Without this explicit config option, an untracked and unused `doc/rtd/spelling_wordlist.txt` file is created while running `tox -e doc-spelling`.
85d6040
to
677ed5f
Compare
TheRealFalcon
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll let you add the PR number to the commits and then you can merge yourself.
blackboxsw
pushed a commit
that referenced
this pull request
Jul 25, 2024
Without this explicit config option, an untracked and unused `doc/rtd/spelling_wordlist.txt` file is created while running `tox -e doc-spelling`.
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Aug 2, 2024
Without this explicit config option, an untracked and unused `doc/rtd/spelling_wordlist.txt` file is created while running `tox -e doc-spelling`.
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Aug 2, 2024
holmanb
pushed a commit
that referenced
this pull request
Aug 6, 2024
Without this explicit config option, an untracked and unused `doc/rtd/spelling_wordlist.txt` file is created while running `tox -e doc-spelling`.
holmanb
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits:
fix(doc-spelling): config spelling_word_list_filename
chore: remove unneeded doc-lint tox env config
Proposed Commit Message
Additional Context
Test Steps
tox -e doc-spelling
Merge type