Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-spelling fixes #5547

Merged
merged 2 commits into from
Jul 25, 2024
Merged

doc-spelling fixes #5547

merged 2 commits into from
Jul 25, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Jul 25, 2024

See individual commits:

fix(doc-spelling): config spelling_word_list_filename
chore: remove unneeded doc-lint tox env config

Proposed Commit Message

Additional Context

Test Steps

tox -e doc-spelling

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions bot added the documentation This Pull Request changes documentation label Jul 25, 2024
Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

aciba90 added 2 commits July 25, 2024 12:16
Without this explicit config option, an untracked and unused
`doc/rtd/spelling_wordlist.txt` file is created while running
`tox -e doc-spelling`.
@aciba90 aciba90 force-pushed the fix-spelling-wordlist branch from 85d6040 to 677ed5f Compare July 25, 2024 10:16
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let you add the PR number to the commits and then you can merge yourself.

@blackboxsw blackboxsw merged commit 25058e1 into canonical:main Jul 25, 2024
24 checks passed
blackboxsw pushed a commit that referenced this pull request Jul 25, 2024
Without this explicit config option, an untracked and unused
`doc/rtd/spelling_wordlist.txt` file is created while running
`tox -e doc-spelling`.
@aciba90 aciba90 deleted the fix-spelling-wordlist branch July 26, 2024 06:43
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
Without this explicit config option, an untracked and unused
`doc/rtd/spelling_wordlist.txt` file is created while running
`tox -e doc-spelling`.
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
holmanb pushed a commit that referenced this pull request Aug 6, 2024
Without this explicit config option, an untracked and unused
`doc/rtd/spelling_wordlist.txt` file is created while running
`tox -e doc-spelling`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants