tests: ec2 check status exit code instead of cloud-init init --local #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 2 | ||
| if should_log_deprecation( | ||
| "24.3", get_feature_flag_value(client, "DEPRECATION_INFO_BOUNDARY") | ||
| ) | ||
| else 0 | ||
| ) | ||
| assert client.execute("cloud-init clean --logs") | ||
| assert return_code == client.execute("cloud-init init --local").return_code | ||
| assert status_code == client.execute("cloud-init status").return_code |
There was a problem hiding this comment.
I don't think there's any reason to be checking cloud-init status in this test. That was never the point of this test.
I think we should just revert this file to its state prior to https://github.com/canonical/cloud-init/pull/5209/files#diff-53a08506f1820f460078130200aee26e99c5a8f151d99367acfef2d7db5020beR12
blackboxsw
force-pushed
the
tests-ec2-status-for-deprecation
branch
2 times, most recently
from
f35ef37 to
1b9bb92
Compare
Commit 604d80e introduced assertions expecting exit 2 from the CLI when calling cloud-init init --local. Revert this test assertion as only cloud-init status command exits (2) on deprecations/warnings. Invoking cloud-init's boot stages on the commmand line will only exit 1 if critical errors are encountered to avoid degrading overall systemd health as seen from cloud-init systemd units. When cloud-init boot stages encounter recoverable_errors of any type, there is no need to exit non-zero as those deprecation logs are not-critical to the health of the system as a whole.
blackboxsw
force-pushed
the
tests-ec2-status-for-deprecation
branch
from
1b9bb92 to
a6b4206
Compare
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Aug 2, 2024
…onical#5504) Commit 604d80e introduced assertions expecting exit 2 from the CLI when calling cloud-init init --local. Revert this test assertion as only cloud-init status command exits (2) on deprecations/warnings. Invoking cloud-init's boot stages on the commmand line will only exit 1 if critical errors are encountered to avoid degrading overall systemd health as seen from cloud-init systemd units. When cloud-init boot stages encounter recoverable_errors of any type, there is no need to exit non-zero as those deprecation logs are not-critical to the health of the system as a whole.
holmanb
pushed a commit
that referenced
this pull request
Aug 6, 2024
Commit 604d80e introduced assertions expecting exit 2 from the CLI when calling cloud-init init --local. Revert this test assertion as only cloud-init status command exits (2) on deprecations/warnings. Invoking cloud-init's boot stages on the commmand line will only exit 1 if critical errors are encountered to avoid degrading overall systemd health as seen from cloud-init systemd units. When cloud-init boot stages encounter recoverable_errors of any type, there is no need to exit non-zero as those deprecation logs are not-critical to the health of the system as a whole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Expected integration test failure on ec2 with daily PPA tomorrow because cloud-init init --local (or any direct call to cloud-init stage doesn't actually exit non-zero because we didn't want cloud-init systemd units/services to degrade overall systemd health based on recoverable_errors.
Test Steps
Merge type