-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openbsd): fix mtu on newline in hostname files #5412
Conversation
49f1cfd
to
c858027
Compare
@tobias-urdin , thanks for the PR. Changes look good to me according to https://man.openbsd.org/ifconfig.8 . Before we can accept your change, you need to sign the CLA and add your Github username (alphabetically) to the cla signers file . The full details are described in the documentation |
The /etc/hostname.* files should have the mtu on a separate line otherwise it gives error: ifconfig: mtu: bad value The lines are executed in order by ifconfig and mtu should be on it's own line. Fixes: canonicalGH-5413
c858027
to
95ae5c0
Compare
Thanks, done now. |
@igalic Hey Meena, would you mind taking a peak at this PR please? |
@tobias-urdin thank you for this contribution! Would you mind modifying your PR description so that it matches the expected PR template/format? |
Done. |
@tobias-urdin thank you so much!! |
I'm going to go ahead and merge this as-is. Some excepts from the
Further down:
and
As currently implemented, If an option including the |
The /etc/hostname.* files should have the mtu on a separate line otherwise it gives error: ifconfig: mtu: bad value The lines are executed in order by ifconfig and mtu should be on it's own line. Fixes: canonicalGH-5413
The /etc/hostname.* files should have the mtu on a separate line otherwise it gives error: ifconfig: mtu: bad value The lines are executed in order by ifconfig and mtu should be on it's own line. Fixes: GH-5413
Proposed Commit Message
Additional Context
Test Steps
use cloud-init with a config drive instead of dhcp
Merge type