Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/archive/archive.go - ubuntuAnimals should be ubuntuAdjectives #16

Closed
ColinIanKing opened this issue Jul 25, 2022 · 0 comments · Fixed by #38
Closed

internal/archive/archive.go - ubuntuAnimals should be ubuntuAdjectives #16

ColinIanKing opened this issue Jul 25, 2022 · 0 comments · Fixed by #38

Comments

@ColinIanKing
Copy link

internal/archive/archive.go: poor naming of map, these are adjectives not Animals.

var ubuntuAnimals = map[string]string{
"18.04": "bionic",
"20.04": "focal",
"22.04": "jammy",
"22.10": "kinetic",
}
iainlane added a commit to iainlane/chisel that referenced this issue Nov 7, 2022
@iainlane
setup: Rename ubuntuAnimals to ubuntuAdjectives
07b36fc 
It's actually a map from release number to adjective, not animal as it
was named.

Closes canonical#16
@iainlane iainlane mentioned this issue Nov 7, 2022
Merged
iainlane added a commit to iainlane/chisel that referenced this issue Nov 7, 2022
@iainlane
setup: Rename ubuntuAnimals to ubuntuAdjectives
5ecc8c1 
It's actually a map from release number to adjective, not animal as it
was named.

Closes canonical#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

setup: Rename ubuntuAnimals to ubuntuAdjectives iainlane/chisel
1 participant
@ColinIanKing