Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Flask to 2.3.3 and update dependencies #72

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Jul 2, 2024

Done

  • Updates Flask to 2.3.3
  • Update other requirements where needed to be compatible

QA

@carkod
Copy link

carkod commented Jul 4, 2024

Can you bump the version of flask-base? if you don't do it won't automatically trigger a renovate PR and you can't really reference it in the requirements.txt.

Also, lint and test are stuck, can you take a look? Maybe rebase could work as I've merged the new versions of actions/checkout

@petesfrench
Copy link
Contributor Author

@samhotep Any idea why these checks are hanging?

@petesfrench
Copy link
Contributor Author

@carkod Can you take another look please

@carkod
Copy link

carkod commented Jul 4, 2024

@samhotep Any idea why these checks are hanging?

Try updating the labels.

Screenshot 2024-07-04 at 18 53 04

By labels I mean the Ubuntu version there.
If we are still using Github runners, then that image is deprecated
otherwise, I think we need to reach out to the Github actions self-hosted runners team

Bump CI ubuntu version
@samhotep
Copy link
Member

samhotep commented Jul 5, 2024

As @carkod suggested I've updated the versions, but the checks are borked now - taking a look

@samhotep
Copy link
Member

samhotep commented Jul 5, 2024

@petesfrench some tests are failing,

you're almost good to merge :)

@petesfrench petesfrench merged commit 0095840 into main Jul 5, 2024
4 checks passed
@petesfrench petesfrench deleted the wd-12659 branch July 5, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants