Apply suggestions from code review

Co-authored-by: Jonas Wanke <[email protected]>
candy-lang · Feb 23, 2023 · 2baa728 · 2baa728 · jwbot · Feb 23, 2023
1 parent a4ebf7a
commit 2baa728
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/compiler/frontend/src/hir_to_mir.rs b/compiler/frontend/src/hir_to_mir.rs
@@ -476,7 +476,7 @@ impl<'a> LoweringContext<'a> {
                 body.push_call(
                     builtin_if_else,
                     vec![is_match, then_lambda, else_lambda],
-                    responsible_for_needs,
+                    responsible_for_match,
                 )
             }
         }

diff --git a/packages/Core/fixedDecimal.candy b/packages/Core/fixedDecimal.candy
@@ -1,4 +1,4 @@
-# As soon as tags or value hiding is supported, change fixed point numbers to
+# TODO: As soon as tags or value hiding is supported, change fixed point numbers to
 # that. Currently, they're just normal ints.
 
 bool = use "..bool"
@@ -14,16 +14,16 @@ decimalsPow = 10000000
 is := int.is
 
 fromInt a :=
-  needs (is a)
-  int.multiply a decimalsPow
+  needs (int.is a)
+  a | int.multiply decimalsPow
 
 floorToInt a :=
   needs (is a)
-  int.divideTruncating a decimalsPow
+  a | int.divideTruncating decimalsPow
 
 isNonNegative a :=
   needs (is a)
-  int.isNonNegative a
+  a | int.isNonNegative
 
 add a b :=
   needs (is a)
Benchmark suite	Current: `2baa728`	Previous: `22fe978`	Ratio
`Time: Compiler/hello_world`	`30474746` ns/iter (`± 976729`)	`29031946` ns/iter (`± 1363210`)	`1.05`
`Time: Compiler/fibonacci`	`727034991` ns/iter (`± 17005604`)	`708862818` ns/iter (`± 22941978`)	`1.03`
`Time: VM Runtime/hello_world`	`23898831` ns/iter (`± 603023`)	`22144452` ns/iter (`± 1511125`)	`1.08`
`Time: VM Runtime/fibonacci/15`	`212976859` ns/iter (`± 1486307`)	`245913884` ns/iter (`± 4986800`)	`0.87`