Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable google java format settings #240

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix: enable google java format settings #240

merged 1 commit into from
Mar 7, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Mar 7, 2022 •
edited
Loading

Description

Saving a file on IntelliJ would result in different formatting than applying spotless. This was because the google java format settings were not enabled.
This commit enables google java format, which should resolve the dicrepancy between IntelliJ and spotless.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@remcowesterhoud
fix: enable google java format settings
49ed959 
Saving a file on IntelliJ would result in different formatting than applying spotless. This was because the google java format settings were not enabled.
This commit enables google java format, which should resolve the dicrepancy between IntelliJ and spotless.
@remcowesterhoud remcowesterhoud requested a review from pihme March 7, 2022 09:56
pihme
pihme approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@pihme pihme merged commit bfe830d into main Mar 7, 2022
@pihme pihme deleted the automatic_formatting branch March 7, 2022 10:06
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Unit Test Results

128 files  128 suites   7m 1s ⏱️
325 tests 325 ✔️ 0 💤 0 ❌
788 runs  788 ✔️ 0 💤 0 ❌

Results for commit 49ed959.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pihme pihme pihme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcowesterhoud @pihme