Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extract methods to extracting #235

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Rename extract methods to extracting #235

merged 1 commit into from
Mar 3, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Mar 3, 2022

Description

We should be consistent with the naming of our methods. At some places we used extractX, in other we used extractingX. They have all been changed to extractingX. This is consistent with the naming of AssertJ (e.g. assertThat(Map).extracting()).

Related issues

closes #217

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

We should be consistent with the naming of our methods. At some places we used extractX, in other we used extractingX. They have all been changed to extractingX. This is consistent with the naming of AssertJ (e.g. assertThat(Map).extracting()).
@remcowesterhoud remcowesterhoud requested a review from pihme March 3, 2022 12:52
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Unit Test Results

128 files  128 suites   6m 53s ⏱️
325 tests 325 ✔️ 0 💤 0
788 runs  788 ✔️ 0 💤 0

Results for commit 0392244.

@pihme pihme merged commit a47773a into main Mar 3, 2022
@pihme pihme deleted the 217_extracting branch March 3, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generify naming of extract methods (sometimes extract.., other times extracting..)
2 participants