Flatten all POMs for deployment #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the `flatten-maven-plugin` in the build process. The projects are flattened according to the `ossrh` rules.
|
@korthout I think Nicolas didn't get around to reviewing this before his vacation. We did want this to part of alpha2. Since you also reviewed the same change in Zeebe could have have quick look at this one as well? It's the same change, but smaller. |
remcowesterhoud
requested review from
korthout
and removed request for
npepinpe
|
Sure. I'm currently finishing up camunda/camunda#8833. I'll have a look once that is done. EDIT: I'll have a look tomorrow morning |
korthout
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Looking good @remcowesterhoud
I have a few suggestions, but nothing blocking 👍
|
@korthout Thanks for the review 🙇 I've added descriptions to all modules and removed the |
The flatten-maven-plugin uses the closest description it can find to put in the flattened pom. Since none of the modules contained a description it would take the one of the community-hub-release-parent. We don't want this descrition, so to solve it a description has been added to each module.
The combine.children property is not useful here. This is because none of the child modules add any configuration to this plugin, so there is never any configuration to append.
remcowesterhoud
force-pushed
the
208-flatten-pom
branch
from
84026d2 to
34366f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
flatten-maven-pluginin the build process. The projects are flattened according to theossrhrules.Related issues
closes #208
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: