Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stable/8.7 CI #1499

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Fix stable/8.7 CI #1499

merged 3 commits into from
Feb 17, 2025

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Feb 17, 2025

Description

This fixes the currently broken stable/8.7 CI, by:

Otherwise dependency management from parent on jackson get lost and the spring bom won, causing a version divergence.
Copy link

github-actions bot commented Feb 17, 2025

Test Results

 50 files  ±0   50 suites  ±0   1m 38s ⏱️ +7s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
438 runs  ±0  438 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6678c47. ± Comparison against base commit fdda8c2.

♻️ This comment has been updated with latest results.

Not needed for covergence management, as there is no conflict anymore.
@@ -73,7 +73,6 @@
<dependency.feel.version>1.17.7</dependency.feel.version>
<dependency.findbugs.version>3.0.2</dependency.findbugs.version>
<dependency.guava.version>33.2.0-jre</dependency.guava.version>
<dependency.httpcore5.version>5.2.5</dependency.httpcore5.version>
Copy link
Contributor Author

@megglos megglos Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this conflicted with camunda/camunda already being on a new minor release of http core. I decided to remove it as there is no convergence issue anymore.

It's manged via spring-boot bom.
@megglos megglos changed the title [backport stable/8.7] ci: move spring boot dependency management to parent Fix stable/8.7 CI Feb 17, 2025
@megglos
Copy link
Contributor Author

megglos commented Feb 17, 2025

tagging @rodrigo-lourenco-lopes as release manager, this should have been blocking the latest alpha release too, right?

@rodrigo-lourenco-lopes
Copy link
Contributor

tagging @rodrigo-lourenco-lopes as release manager, this should have been blocking the latest alpha release too, right?

@megglos I was not aware of this issue, should this have been in the alpha release?

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@megglos
Copy link
Contributor Author

megglos commented Feb 17, 2025

tagging @rodrigo-lourenco-lopes as release manager, this should have been blocking the latest alpha release too, right?

@megglos I was not aware of this issue, should this have been in the alpha release?

if the alpha release build was still fine, no, this seems to have been caused by recent renovate updates on the mono-repo

@megglos megglos merged commit 660e466 into stable/8.7 Feb 17, 2025
10 checks passed
@megglos megglos deleted the meg-fix-spring-dep-management branch February 17, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants