Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable timer test #1233

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

koevskinikola
Copy link
Member

Description

The TimerTest is failing due to an issue with the
process scheduling service in the Zeebe eninge.
The test is disabled to unblock the release of
ZPT while we continue working on a permanent fix
for the test.

Related issues

related to #1230

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

The TimerTest is failing due to an issue with the
process scheduling service in the Zeebe eninge.
The test is disabled to unblock the release of
ZPT while we continue working on a permanent fix
for the test.
@koevskinikola koevskinikola requested a review from nicpuppa August 28, 2024 08:25
@koevskinikola koevskinikola self-assigned this Aug 28, 2024
@koevskinikola
Copy link
Member Author

koevskinikola commented Aug 28, 2024

@nicpuppa I'm disabling the TimerTests with this PR so the ZPR release is unblocked.

UPDATE: I applied a new backport release-8.6.0-alpha5 label so the disabling is backported to the release branch.

@nicpuppa
Copy link
Contributor

Should we disable those test only on the release branch ? @koevskinikola

Copy link

Test Results

 49 files   - 1   49 suites   - 1   1m 24s ⏱️ -1s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
435 runs   - 3  435 ✅  - 3  0 💤 ±0  0 ❌ ±0 

Results for commit 7080833. ± Comparison against base commit 848365f.

@koevskinikola
Copy link
Member Author

@nicpuppa that's a good point. Better to leave them visible on main so we don't delay the fix. I'll rebase this PR on the release branch.

@koevskinikola koevskinikola changed the base branch from main to release-8.6.0-alpha5 August 28, 2024 08:38
@koevskinikola koevskinikola merged commit 620e486 into release-8.6.0-alpha5 Aug 28, 2024
10 checks passed
@koevskinikola koevskinikola deleted the 1230-disable-timer-test branch August 28, 2024 08:38
@nicpuppa
Copy link
Contributor

/backport

@backport-action
Copy link
Collaborator

Successfully created backport PR for main:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants