Refactor File resolving #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing files in a jar was quite hard and error prone, which is why we move away from it and use direct paths (per default relative) which can be overwritten via env variable. Useful in docker image.
instead of the containing everything in the jar we now contain the chaos resources in the docker image, which makes it easier accessible by our worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing files in a jar was a nightmare. It was quite hard to do it right and error prone, which is why we move away from it and use direct paths (per default relative) which can be overwritten via env variable.
On creating the docker image we copy all chaos experiment resources, experiments, scripts etc. We set the correct env var which allows to access the files without any issues.
Run an integration test with an own cluster (chaos orchestrator) and a chaos target cluster.
Chaos experiment execution can be monitored quite good in operate: