Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to [email protected] #124

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ All notable changes to [@camunda/linting](https://github.com/camunda/linting) ar

___Note:__ Yet to be released changes appear here._

## 3.29.1

* `FIX`: relax `task-listener` to not check implementation type ([camunda/bpmnlint-plugin-camunda-compat#182](https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/182))
* `FIX`: do not mark job worker user task as incorrect
* `FIX`: remove `zeebe-user-task` rule
* `DEPS`: update to `[email protected]`

## 3.29.0

* `FEAT`: support for task listeners ([#123](https://github.com/camunda/linting/pull/123))
Expand Down
9 changes: 2 additions & 7 deletions lib/compiled-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ const rules = {
"camunda-compat/user-task-definition": "warn",
"camunda-compat/user-task-form": "error",
"camunda-compat/version-tag": "error",
"camunda-compat/wait-for-completion": "error",
"camunda-compat/zeebe-user-task": "error"
"camunda-compat/wait-for-completion": "error"
};

const config = {
Expand Down Expand Up @@ -278,8 +277,4 @@ cache['bpmnlint-plugin-camunda-compat/version-tag'] = rule_45;

import rule_46 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/wait-for-completion';

cache['bpmnlint-plugin-camunda-compat/wait-for-completion'] = rule_46;

import rule_47 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/zeebe-user-task';

cache['bpmnlint-plugin-camunda-compat/zeebe-user-task'] = rule_47;
cache['bpmnlint-plugin-camunda-compat/wait-for-completion'] = rule_46;
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@bpmn-io/diagram-js-ui": "^0.2.3",
"bpmn-moddle": "^9.0.1",
"bpmnlint": "^10.3.1",
"bpmnlint-plugin-camunda-compat": "^2.28.0",
"bpmnlint-plugin-camunda-compat": "^2.28.1",
"bpmnlint-utils": "^1.0.2",
"camunda-bpmn-moddle": "^7.0.1",
"clsx": "^2.0.0",
Expand Down
18 changes: 0 additions & 18 deletions test/spec/utils/error-messages.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -678,24 +678,6 @@ describe('utils/error-messages', function() {
// then
expect(errorMessage).to.equal('A <User Task> should have a defined <Form>');
});


it('should adjust (zeebe user task)', async function() {

// given
const node = createElement('bpmn:UserTask');

const { default: rule } = await import('bpmnlint-plugin-camunda-compat/rules/camunda-cloud/zeebe-user-task');

const report = await getLintError(node, rule, { version: '8.7' });

// when
const errorMessage = getErrorMessage(report);

// then
expect(errorMessage).to.equal('A <User Task> must have <Implementation: Zeebe user task>');
});

});


Expand Down
21 changes: 0 additions & 21 deletions test/spec/utils/properties-panel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1090,27 +1090,6 @@ describe('utils/properties-panel', function() {
});


it('zeebe-user-task', async function() {

// given
const node = createElement('bpmn:UserTask', {
id: 'UserTask_1'
});

const { default: rule } = await import('bpmnlint-plugin-camunda-compat/rules/camunda-cloud/zeebe-user-task');

const report = await getLintError(node, rule, { version: '8.7' });

// when
const entryIds = getEntryIds(report);

// then
expect(entryIds).to.eql([ 'userTaskImplementation' ]);

expectErrorMessage(entryIds[ 0 ], 'Not supported.', report);
});


it('inclusive-gateway (no condition expression)', async function() {

// given
Expand Down
Loading