Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set error message for duplicate-task-headers rule #12

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Aug 15, 2022

Requires camunda/bpmnlint-plugin-camunda-compat#41
Closes #4

Note this is added for all Camunda 8 versions, as it has been failing on deployment since the first supported Zeebe version (cf. #4 (comment)).


image

Copy link
Contributor Author

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initiative! Looks really promising, I will take a deeper look on this one + the rules PR once I'm back 👍

@philippfromme
Copy link
Collaborator

I made a proposal to refactor this before we merge it (cf. 33d0381). @pinussilvestrus will have a look at the proposal and we'll squash before merging.

@pinussilvestrus
Copy link
Contributor Author

✅ from my side 👍 (cf. camunda/bpmnlint-plugin-camunda-compat#41 (review)).

Let's merge and release the rule and bring this out of the door.

Copy link
Collaborator

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippfromme philippfromme merged commit f545506 into main Aug 18, 2022
@philippfromme philippfromme deleted the 4-duplicate-headers branch August 18, 2022 12:16
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on duplicate key in custom headers
2 participants