feat: add function is blank() to check if a string is blank
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
requested changes
Sep 20, 2024
Comment on lines
74
to
79
| private def isBlankFunction = builtinFunction( | ||
| params = List("string"), | ||
| invoke = {case List(ValString(string)) => | ||
| ValBoolean(string.isBlank) | ||
| } | ||
| ) |
There was a problem hiding this comment.
❌ Since is blank() is a function for a string argument, we should add the function to StringBuiltinFunctions.
BooleanBuiltinFunctions is for functions with a boolean argument.
| @@ -243,4 +243,27 @@ class BuiltinFunctionsTest | |||
| "Assertion failure on evaluate the expression 'list contains(assert(my_list, my_list != null, \"The condition is not true\"), 2)': The condition is not true" | |||
| ) | |||
| } | |||
|
|
|||
| "A is blank() function" should "return Boolean" in { | |||
There was a problem hiding this comment.
❌ Same as the implementation, we should add the test cases to BuiltinStringFunctionsTest.
Comment on lines
248
to
266
| evaluateExpression( | ||
| expression = """ is blank("") """ | ||
| ) should returnResult(true) | ||
|
|
||
| evaluateExpression( | ||
| expression = """ is blank(" ") """ | ||
| ) should returnResult(true) | ||
|
|
||
| evaluateExpression( | ||
| expression = """ is blank("hello world") """ | ||
| ) should returnResult(false) | ||
|
|
||
| evaluateExpression( | ||
| expression = """ is blank(" hello world ") """ | ||
| ) should returnResult(false) | ||
|
|
||
| evaluateExpression( | ||
| expression = """ is blank("\t\n\r\f") """ | ||
| ) should returnResult(true) |
There was a problem hiding this comment.
🔧 We could split the test cases into:
should "return true if the string contains only whitespace"should "return false if the string contains non-whitespace characters"
Comment on lines
248
to
250
| evaluateExpression( | ||
| expression = """ is blank("") """ | ||
| ) should returnResult(true) |
There was a problem hiding this comment.
❌ Add one more test case that verifies the invocation of the function with named parameters:
evaluateExpression(
expression = """ is blank(string: "") """
) should returnResult(true)
This kind of test ensures that we don't change the parameter name accidentally.
This was referenced Sep 20, 2024
saig0
added
the
follow-up: camunda docs
|
Hi, @saig0 , It's done, please check again. |
saig0
approved these changes
Sep 20, 2024
src/test/scala/org/camunda/feel/impl/builtin/BuiltinStringFunctionsTest.scala
Outdated
Show resolved
Hide resolved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add function
is blank()to check if a string is blankRelated issues
related to camunda/camunda#22380