Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.15] fix(builtin-function): fix string conversion of years-months-durations #647

Merged
merged 2 commits into from
May 26, 2023
Merged

[Backport 1.15] fix(builtin-function): fix string conversion of years-months-durations #647

merged 2 commits into from
May 26, 2023

Conversation

github-actions[bot]
Copy link

Description

Backport of #644 to 1.15.

relates to #636 #631

saig0 and others added 2 commits May 26, 2023 08:35
@saig0 @github-actions
build: Ignore inner methods for Clirr
7576078 
Clirr reports a false positive if an inner method is changed. Adjust the configuration of the Clirr plugin to ignore these errors.

(cherry picked from commit f9fde28)
(cherry picked from commit 0aade7c)
@s-frick @github-actions
fix(builtin-function): fix string conversion of years-months-durations
33f0222 
* add tests for string conversion of zero-length years-months-duration
* add tests for string conversion of negative years-months-duration

(cherry picked from commit 38c8e38)
(cherry picked from commit 9b5614c)
@github-actions github-actions bot mentioned this pull request May 26, 2023
Merged
@saig0 saig0 changed the title [Backport 1.15] [Backport 1.16] fix(builtin-function): fix string conversion of years-months-durations [Backport 1.15] fix(builtin-function): fix string conversion of years-months-durations May 26, 2023
@saig0 saig0 merged commit d256a38 into 1.15 May 26, 2023
@saig0 saig0 deleted the backport-644-to-1.15 branch May 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saig0 @s-frick