Add new get value function with dynamic path #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koevskinikola
force-pushed
the
11293-dynamic-path-get-value
branch
from
d55837b to
9dc728b
Compare
saig0
requested changes
Mar 15, 2023
There was a problem hiding this comment.
@koevskinikola thank you for driving our mob programming session. 🚀
❌ I found one case that could lead to a cast exception in Zeebe.
❌ We need to document the new function.
🔧 I have an idea to refactor the function a bit.
Please have a look at my comments. Happy to answer your questions or discuss/code f2f. 🍪
src/main/scala/org/camunda/feel/impl/builtin/ContextBuiltinFunctions.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/camunda/feel/impl/builtin/ContextBuiltinFunctions.scala
Outdated
Show resolved
Hide resolved
Add test coverage for the new get value function where you can pass a dynamic path to get a value out of a given context.
Add a new get value function with a new signature. With this function, a user can dynamically pass a path to obtain a nested property in a given context.
Document the newly supported getValue built-in function which supports providing a path (as a list of context keys) for which to obtain a nested context entry.
koevskinikola
force-pushed
the
11293-dynamic-path-get-value
branch
from
9dc728b to
8d6657d
Compare
|
@saig0 I implemented your review hints. I also restructured the commits a bit, so they are merge-ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new get value function with a new signature. With this function, a user can dynamically pass a path to obtain a nested property in a given context.
Related issues
closes #11293