Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instance-of doesn't work for the type "date and time" #597

Merged
merged 3 commits into from
Mar 10, 2023
Merged

instance-of doesn't work for the type "date and time" #597

merged 3 commits into from
Mar 10, 2023

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Mar 7, 2023

Description

Use the correct type name date and time for the instance of expression. Previously, it uses the wrong type name date time.

// DMN compliant 
@"2018-12-08T10:30:11" instance of date and time

// vs.

// not DMN compliant
@"2018-12-08T10:30:11" instance of date time

Support the previous type name for backward compatibility.

Related issues

closes #543

saig0 added 3 commits March 7, 2023 15:06
@saig0
test: verify instance-of behavior
62c8ad0 
Add new test cases to verify the instance-of expression behavior.
@saig0
fix: instance-of for date-time
1bf391c 
Use the correct type name "date and time" for the instance-of expression. Previously, it uses the wrong type name "date time".

Support the previous type name for backward-compatibility.
@saig0
docs: correct the type name for instance-of
4cd7847
@saig0 saig0 requested a review from berkaycanbc March 9, 2023 11:20
berkaycanbc
berkaycanbc approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@berkaycanbc berkaycanbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 🚀

@saig0 saig0 merged commit 11571eb into main Mar 10, 2023
@saig0 saig0 deleted the 543-instance-of branch March 10, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkaycanbc berkaycanbc berkaycanbc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instance of doesn't work for date and time
2 participants
@saig0 @berkaycanbc