-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Instance of with correct duration names #535
Conversation
@sccalabr thank you for your contribution. 🎉 I'll have a look at your PR in the next few days. 👀 |
Does this look good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"duration("P3M") instance of years and months duration" | ||
// true | ||
|
||
"duration("PT4H") instance of days and time duration" | ||
// true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ The expression is wrapped into double quotes.
"duration("P3M") instance of years and months duration" | |
// true | |
"duration("PT4H") instance of days and time duration" | |
// true | |
duration("P3M") instance of years and months duration | |
// true | |
duration("PT4H") instance of days and time duration | |
// true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ We should update the type names in the description above.
We can replace the old names for the duration types. A user should use the official type names.
Description
Expected behavior
null instance of years and months duration -> false
null instance of days and time duration -> false
duration("P3M") instance of years and months duration -> true
duration("PT4H") instance of days and time duration -> true
Related issues
closes #155