-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NumericBuiltinFunction): Add random number function #528
Conversation
Signed-off-by: Kasper Aaquist Johansen <[email protected]>
Signed-off-by: Kasper Aaquist Johansen <[email protected]>
Still needed documentation and I also have a question in regards to test. I would like to test it the number returned is between 0.0f and 1.0f. I have created a test that I would expect would pass but I get an exception. it should "return a number between 0.0 and 1.0 " in {
eval(" random number() ") should (be >= ValNumber(0.0) and be <= ValNumber(1.0))
} Exception:
|
Nice try. 👍 Instead, you could use a For example:
|
Signed-off-by: Kasper Aaquist Johansen <[email protected]>
Signed-off-by: Kasper Aaquist Johansen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaaquist thank you for your contribution. 🎉
The changes look good. 👍 I have only a few minor comments.
Description
Related issues
closes #506