[Backport 1.15] fix: filter expression with numeric function #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- a list should be filtered with a numeric function - the expression should return the element based on the index that is returned from the numeric function (cherry picked from commit a9d42ce)
- if the filter of a list returns a number then the expression should return the item at the given index - note that the code could look more elegant but we want to avoid unintended function invocation because the invocations are visible by the function provider (#359) - we could improve the code later if the function defines the types of the arguments and the return value (#295) (cherry picked from commit a2bcf5b)
- if the filter function returns a number then it should be invoked only once (cherry picked from commit 5373c0e)
- the expression should fail if the filter doesn't return a boolean or number - it should fail if the filter doesn't return always a boolean after the first invocation (cherry picked from commit e7d6f9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #514 to
1.15.relates to #507