Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live FEEL tutorial component #486

Merged
merged 7 commits into from
Aug 11, 2022
Merged

Live FEEL tutorial component #486

merged 7 commits into from
Aug 11, 2022

Conversation

korthout
Copy link
Member

Description

  • Builds on top of Update Docusaurus to 2.0 #485
  • Adds Axios for HTTP requests
  • Adds Use-Editable to build an Editor component
  • Adds a LiveFeel component that:
    • allows you to write a FEEL expression with an Editor
    • allows you to add a FEEL context with an Editor
    • allows you to evaluate the expression with the context
    • shows the result
  • embeds the LiveFeel component in a MDX page tutorial-test.mdx

The PR is still a draft, because it introduces a test page, and waits for the merging of #485.

@korthout korthout changed the title Live FEEL tutorial Live FEEL tutorial component Aug 10, 2022
@upgradingdave upgradingdave force-pushed the korthout-live-feel-editor branch from 9097d0b to e004a2c Compare August 11, 2022 01:09
korthout and others added 7 commits August 11, 2022 06:02
@korthout @saig0
build(docs): update package-lock to v2
8016b64 
The new package-lock version contains more details and is more explicit.
Before updating packages with npm it makes sense to update this.
@korthout @saig0
deps(docs): bump docusaurus to 2.0.1
c8d9301
@korthout @saig0
deps(docs): update to fix webpack
6fc0421 
See:
- facebook/docusaurus#5778
- TypeStrong/ts-node#1645
@korthout @saig0
deps(docs): install axios for http requests
01ccce7 
With almost 100k GH stars, this is one of the most commonly used HTTP
libraries for nodejs.
@korthout @saig0
deps(docs): install use-editable
83392e9 
This library allows us to build an editable React component.
@korthout @saig0
feat(docs): add tutorial-test page
e681e30 
Adds a test page (MDX) called `tutorial-test.mdx` to develop the
LiveFeel and Editor components.
@saig0
docs: add tutorial test page to sidebar
031852d 
* make it easy to play around with the new editor
@saig0 saig0 force-pushed the korthout-live-feel-editor branch from e004a2c to 031852d Compare August 11, 2022 04:20
@saig0 saig0 self-requested a review August 11, 2022 04:20
@saig0 saig0 marked this pull request as ready for review August 11, 2022 04:20
saig0
saig0 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korthout awesome 🤩 That is a great result 🚀

image

@saig0 saig0 merged commit 940148c into master Aug 11, 2022
@saig0 saig0 deleted the korthout-live-feel-editor branch August 11, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korthout @saig0