chore(project): morph into a single module project #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
saig0
commented
Jun 5, 2020
saig0
commented
- moved the feel-engine module into root
- remove example module - examples and tests are covered by the engine module
- remove SBT as build tool in favor of Maven - maintaining both build tools and keep them in sync is too much work
saig0
requested review from
tasso94 and
koevskinikola
and removed request for
tasso94
koevskinikola
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Looks good to me! I also tested the changes locally with the DMN Engine in the platform. It all works well.
@saig0 can you rebase the branch before merging?
* moved the feel-engine module into root * remove example module (examples and tests are covered by the engine module)
Bumps [camunda-release-parent](https://github.com/camunda/camunda-release-parent) from 3.3 to 3.7. - [Release notes](https://github.com/camunda/camunda-release-parent/releases) - [Commits](camunda/camunda-release-parent@3.3...3.7) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
|
@koevskinikola, done 🎉 Thanks for checking the compatibility 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.