Support activating Inclusive Gateway via Process Instance Modification #25771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a similar case to shouldActivateParallelGateway() that shows that we can activate an inclusiveGateway (OR gateway) through an activation instruction of Process Instance Modification. This case is rather simple, activating a forking OR gateway with a single incoming sequence flow that has already been activated once before.
Adds a simple implementation to support activation of INCLUSIVE_GATEWAY (OR gateway) through activate instruction of Process Instance Modification. By adding this line, we increment all incoming sequence flows to the gateway as taken once. Note that any previously taken flows, will be simply considered as X+1, where X is the number of times that flow was already taken previously (increment). This means that, when the ProcessInstance:ACTIVATE_ELEMENT command for the gateway is processed, each of the incoming flows have been taken atleast once and so the command is not rejected. When we apply the corresponding ELEMENT_ACTIVATING event, the number of times each incoming sequence flow is decremented again, ensuring that any previously taken flows are still recorded after modification has finished.
This adds a case similar to shouldActivateInclusiveGateway() with some differences. The main goal is to check that any sequence flow that was already taken toward an inclusive gateway is retained after the process instance modification activating that same gateway. This is important to test because of the implementation of activating an inclusive gateway through modification: first increment all incoming sequence flows to the gateway as taken, and then process the activate element command for the gateway which should decrement all those flows again. As we increment and decrement we want to avoid forgetting about any previously taken ones. We can test this by activating a joining inclusive gateway, for which already one sequence flow has been taken. On modification, we expect that it activates even though there is still a token active that can reach the gateway. When that token eventually reaches the gateway, it should trigger again, as all incoming sequence flows have been taken officially now.
korthout
added
backport stable/8.3
tmetzke
approved these changes
Dec 9, 2024
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for activating Inclusive Gateway via a Process Instance Modification.
Specifically, adds the ability to reference an Inclusive Gateway in the activate instructions of a Process Instance Modification command. Previously, such activation instructions had no effect because the
ACTIVATE_ELEMENTcommand for the gateway would be rejected.By incrementing the number of times each of its incoming sequence flows have been taken, we ensure it isn't rejected. These recorded values are decremented again after the gateway has reached the
ELEMENT_ACTIVATINGlifecycle state.These changes ensure that any previously taken sequence flows are retained after the modification has finished.
Related issues
closes #20587
closes #25099