Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay deployed forms #15201

Merged
2 commits merged into from
Nov 14, 2023
Merged

Replay deployed forms #15201

2 commits merged into from
Nov 14, 2023

Conversation

korthout
Copy link
Member

@korthout korthout commented Nov 14, 2023 •
edited
Loading

Description

Includes Form records in the supported Engine records so they are replayed.

A test case is added as a regression test.

Related issues

closes #15194

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@korthout
test(engine): should restore linked form
a5eb68c 
This test fails because of a bug.

It deploys a form alongside a process and creates an instance with a
user task that links the form. After restart, the state must be restored
in such a way that the form can still be linked, but this is not the
case.
@korthout
fix(engine): support form records
38f4e78 
This fixes a bug where form records were not replayed/processed. It was
not noticed because form records don't have commands yet and so
processing was not needed yet. Event applying goes through the event
appliers, so replay was missed.

It solves the bug by including the Form value type in the
SUPPORTED_VALUETYPES enumset.
@korthout korthout added the backport main Forward-port a pull request to main label Nov 14, 2023
@korthout korthout marked this pull request as ready for review November 14, 2023 17:16
@korthout korthout requested a review from a team November 14, 2023 17:16
nicpuppa
nicpuppa approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @korthout ❤️

bors merge

@ghost
Copy link

ghost commented Nov 14, 2023

Build succeeded:

@ghost ghost merged commit 4022374 into stable/8.3 Nov 14, 2023
@ghost ghost deleted the korthout-15194-replay-deployed-form branch November 14, 2023 20:22
@backport-action backport-action mentioned this pull request Nov 14, 2023
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for main:

ghost pushed a commit that referenced this pull request Nov 14, 2023
@korthout
merge: #15202
8cd3534 
15202: [Backport main] Replay deployed forms r=github-actions[bot] a=backport-action

# Description
Backport of #15201 to `main`.

relates to #15194
original author: `@korthout`

Co-authored-by: Nico Korthout <[email protected]>
ghost pushed a commit that referenced this pull request Nov 14, 2023
@korthout
merge: #15202
d1ac7bf 
15202: [Backport main] Replay deployed forms r=github-actions[bot] a=backport-action

# Description
Backport of #15201 to `main`.

relates to #15194
original author: `@korthout`

Co-authored-by: Nico Korthout <[email protected]>
@korthout
Copy link
Member Author

Thanks @nicpuppa for the review and quick forwardport ❤️

@deepthidevaki deepthidevaki added the version:8.4.0 Label that represents issues released on verions 8.4.0 label Jan 4, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicpuppa nicpuppa nicpuppa approved these changes

Assignees
No one assigned
Labels
backport main Forward-port a pull request to main version:8.4.0-alpha2 version:8.4.0 Label that represents issues released on verions 8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@korthout @backport-action @nicpuppa @abbasadel @deepthidevaki