Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link event validation is too strict #4870

Open
2 tasks
barmac opened this issue Feb 28, 2025 · 2 comments · May be fixed by #4876
Open
2 tasks

Link event validation is too strict #4870

barmac opened this issue Feb 28, 2025 · 2 comments · May be fixed by #4876
Assignees
@barmac
Labels
bug Something isn't working in progress Currently worked on linting

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 28, 2025 •
edited
Loading

Describe the bug

The link event lint rule requires to put a name on the event which is not required by the spec. Only the link event definition name must be provided. Also, the error message for missing link in scope refers to the element name while it should mention link event definition name.

Image

Steps to reproduce

  1. Add a link event
  2. now this happens

Expected behavior

  • Display link event definition name for missing link event in scope.
  • Do not require link event name to be provided.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.33
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

Reported via https://camunda.slack.com/archives/C0693F1NFK5/p1740717011951939
@barmac barmac added bug Something isn't working ready Ready to be worked on linting labels Feb 28, 2025
@barmac barmac mentioned this issue Feb 28, 2025
Open
39 tasks
@barmac
Copy link
Collaborator Author

barmac commented Feb 28, 2025

I will have a look at this.

@barmac barmac self-assigned this Feb 28, 2025
barmac added a commit to bpmn-io/bpmnlint that referenced this issue Feb 28, 2025
@barmac
fix: make link-event rule check only BPMN compliance
745d174 
* Link name instead of element name is required and checked for duplicates.
* Multiple link throw elements with the same link name are allowed.

Related to camunda/camunda-modeler#4870
@barmac barmac mentioned this issue Feb 28, 2025
Merged
4 tasks
@barmac
Copy link
Collaborator Author

barmac commented Feb 28, 2025

This will be fixed upstream via bpmn-io/bpmnlint#174

barmac added a commit to bpmn-io/bpmnlint that referenced this issue Feb 28, 2025
@barmac
fix: make link-event rule check only BPMN compliance
03c0501 
* Link name instead of element name is required and checked for duplicates.
* Multiple link throw elements with the same link name are allowed.

Related to camunda/camunda-modeler#4870
@barmac barmac mentioned this issue Feb 28, 2025
Merged
@barmac barmac added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Feb 28, 2025
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Mar 4, 2025
barmac added a commit that referenced this issue Mar 4, 2025
@barmac
deps: update to @camunda/[email protected]
ddbb542 
Closes #4870
@barmac barmac linked a pull request Mar 4, 2025 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working in progress Currently worked on linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update to @camunda/[email protected] camunda/camunda-modeler
1 participant
@barmac