Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Literal expression editor body has small hitbox in BKM #4545

Closed
barmac opened this issue Sep 24, 2024 · 3 comments · Fixed by #4622
Closed

Literal expression editor body has small hitbox in BKM #4545

barmac opened this issue Sep 24, 2024 · 3 comments · Fixed by #4622
Assignees
@jarekdanielak
Labels
bug Something isn't working DMN
Milestone
M82

Comments

@barmac
Copy link
Collaborator

barmac commented Sep 24, 2024 •
edited
Loading

Describe the bug

In an empty literal expression editor of BKM, I need to select the first line to get keyboard focus

Recording 2024-06-06 at 10 38 04

Steps to reproduce

  1. Open a literal expression editor
  2. Click around in the function body
  3. If you do not hit the first line, Keyboard focus is lost/not achieved

Expected behavior

I can click anywhere and the cursor gets positioned at the end of the file

Environment

  • Version: 5.24.0-rc.0, v5.28.0
  • Operating System: Windows 10 amd64
  • Plugins:
  • Execution Platform: DMN - Camunda 8

Additional context

The cursor also suggests that I can click anywhere to edit

SUPPORT-23549

Follow-up of #4342
@barmac barmac added bug Something isn't working DMN labels Sep 24, 2024
@barmac barmac mentioned this issue Sep 24, 2024
Closed
@nikku nikku added the ready Ready to be worked on label Oct 1, 2024
@nikku
Copy link
Member

nikku commented Oct 1, 2024

As this is a follow-up to a proclaimed fix I'm moving this to ready.

@jarekdanielak jarekdanielak self-assigned this Oct 7, 2024
jarekdanielak added a commit to bpmn-io/dmn-js that referenced this issue Oct 10, 2024
@jarekdanielak
fix: fix literal expression editor hitbox in BKM
0d2d5ba 
Related to camunda/camunda-modeler#4545
@jarekdanielak jarekdanielak mentioned this issue Oct 10, 2024
Merged
4 tasks
jarekdanielak added a commit to bpmn-io/dmn-js that referenced this issue Oct 14, 2024
@jarekdanielak
fix: fix literal expression editor hitbox in BKM (#905)
3c08efa 
Related to camunda/camunda-modeler#4545
@jarekdanielak jarekdanielak added the in progress Currently worked on label Oct 14, 2024 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the ready Ready to be worked on label Oct 14, 2024
barmac pushed a commit to bpmn-io/dmn-js that referenced this issue Oct 16, 2024
@jarekdanielak @barmac
fix: fix literal expression editor hitbox in BKM (#905)
67bfb20 
Related to camunda/camunda-modeler#4545
@nikku
Copy link
Member

nikku commented Oct 16, 2024

Fixed upstream via bpmn-io/dmn-js#905.

@nikku nikku added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Oct 16, 2024
@nikku
Copy link
Member

nikku commented Oct 18, 2024

@jarekdanielak Let's release + integrate the fix for this.

@jarekdanielak jarekdanielak mentioned this issue Oct 18, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Oct 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 24, 2024
@github-actions github-actions bot added this to the M82 milestone Oct 24, 2024
@jarekdanielak jarekdanielak mentioned this issue Oct 29, 2024
Closed
38 tasks
github-merge-queue bot pushed a commit to camunda/camunda that referenced this issue Nov 25, 2024
@renovate
deps: Update dependency dmn-js to v16.8.2 (main) (#25179)
d5fb4c3 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [dmn-js](https://github.com/bpmn-io/dmn-js)
([source](https://github.com/bpmn-io/dmn-js/tree/HEAD/packages/dmn-js))
| [`16.7.1` ->
`16.8.2`](https://renovatebot.com/diffs/npm/dmn-js/16.7.1/16.8.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/dmn-js/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/dmn-js/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/dmn-js/16.7.1/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/dmn-js/16.7.1/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bpmn-io/dmn-js (dmn-js)</summary>

###
[`v16.8.2`](https://github.com/bpmn-io/dmn-js/blob/HEAD/packages/dmn-js/CHANGELOG.md#1682)

[Compare
Source](https://github.com/bpmn-io/dmn-js/compare/v16.8.1...v16.8.2)

- `FIX`: make name change behavior not break on name change
([#&#8203;917](https://github.com/bpmn-io/dmn-js/pull/917))

###
[`v16.8.1`](https://github.com/bpmn-io/dmn-js/blob/HEAD/packages/dmn-js/CHANGELOG.md#1681)

[Compare
Source](https://github.com/bpmn-io/dmn-js/compare/v16.8.0...v16.8.1)

- `FIX`: make literal expression editor hitbox bigger in BKM
([camunda/camunda-modeler#4545](https://github.com/camunda/camunda-modeler/issues/4545))
- `FIX`: make literal expression variables table styles explicit
([camunda/camunda-modeler#4550](https://github.com/camunda/camunda-modeler/issues/4550))

###
[`v16.8.0`](https://github.com/bpmn-io/dmn-js/blob/HEAD/packages/dmn-js/CHANGELOG.md#1680)

[Compare
Source](https://github.com/bpmn-io/dmn-js/compare/v16.7.1...v16.8.0)

-   `FEAT`: support Camunda 8 FEEL built-ins
- `FIX`: display parameterless functions suggestion correctly
([#&#8203;898](https://github.com/bpmn-io/dmn-js/issues/898))
-   `FIX`: improve validation of `first-item` FEEL rule
- `FIX`: variable name changes when element name\label changes
([#&#8203;863](https://github.com/bpmn-io/dmn-js/issues/863))
-   `DEPS`: update to `@bpmn-io/[email protected]`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/camunda/camunda).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarekdanielak jarekdanielak

Labels
bug Something isn't working DMN
Projects
None yet
Milestone
M82
Development

Successfully merging a pull request may close this issue.

deps: update dmn-js dependencies camunda/camunda-modeler
3 participants
@nikku @jarekdanielak @barmac