Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When you have a search term that does not resolve it still highlights the element that was previously searched upon. #4538

Closed
GeethaParthasarathy opened this issue Sep 23, 2024 · 1 comment · Fixed by #4641
Closed

When you have a search term that does not resolve it still highlights the element that was previously searched upon. #4538

GeethaParthasarathy opened this issue Sep 23, 2024 · 1 comment · Fixed by #4641
Labels
BPMN bug Something isn't working modeling
Milestone
M82

Comments

@GeethaParthasarathy
Copy link

GeethaParthasarathy commented Sep 23, 2024 •
edited by nikku
Loading

Describe the bug

When you have a search term that does not resolve it still highlights the element that was previously searched upon.

Steps to reproduce

  1. Create a simple bpmn diagram
  2. Add a search term that resolves to an element -> respective element highlighted
  3. Then add a random search term that does not resolve yet we could see that the previously highlighted element still remains highlighted.

Note: This is not the case when no element was highlighted as part of the first search term
Also I used the term "user" and I am not sure how it resolved to the sequence flow

Screen.Recording.2024-09-23.at.11.09.54.mov

Expected behavior

When no element is resolved for a search term do not focus/highlight on any element in the canvas

Environment

OS : Mac os
env : Web Modeler

Additional context

No response

Depends on bpmn-io/diagram-js#931
@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Sep 23, 2024
@philippfromme
Copy link
Contributor

This issue will be addressed by bpmn-io/diagram-js#931.

@philippfromme philippfromme added the backlog Queued in backlog label Sep 24, 2024
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Sep 24, 2024
@philippfromme
feat(search-pad): add custom marker to preselected element
e7efdc7 
Related to camunda/camunda-modeler#4538
@nikku nikku added BPMN modeling fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Sep 24, 2024
@nikku nikku added this to the M82 milestone Sep 24, 2024
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Sep 25, 2024
@philippfromme @nikku
feat(search-pad): add custom marker to preselected element
9e36453 
Related to camunda/camunda-modeler#4538
@nikku nikku mentioned this issue Sep 25, 2024
Merged
4 tasks
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Sep 25, 2024
@philippfromme @nikku
feat(search-pad): add custom marker to preselected element
3f87f09 
Related to camunda/camunda-modeler#4538
@nikku nikku added the ready Ready to be worked on label Oct 29, 2024 — with bpmn-io-tasks
@nikku nikku removed the fixed upstream Requires integration of upstream change label Oct 29, 2024
@nikku nikku modified the milestones: M82, M83 Oct 29, 2024
nikku pushed a commit that referenced this issue Oct 29, 2024
@jarekdanielak @nikku
deps: update modeling dependencies
9c521ba 
deps: update to [email protected]

  Closes #4538

deps: update to [email protected]

deps: update to [email protected]
@nikku nikku mentioned this issue Oct 29, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Oct 29, 2024
nikku pushed a commit that referenced this issue Oct 29, 2024
@jarekdanielak @nikku
deps: update modeling dependencies
7d9f0bb 
deps: update to [email protected]

  Closes #4538

deps: update to [email protected]

deps: update to [email protected]
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 29, 2024
@jarekdanielak jarekdanielak mentioned this issue Oct 29, 2024
Closed
38 tasks
@nikku nikku modified the milestones: M83, M82 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN bug Something isn't working modeling
Projects
None yet
Milestone
M82
Development

Successfully merging a pull request may close this issue.

Bump BPMN and DMN modeling deps camunda/camunda-modeler
3 participants
@nikku @philippfromme @GeethaParthasarathy