Skip to content

Commit

Permalink
fix(BpmnEditor): configure feel tooltip container
Browse files Browse the repository at this point in the history
fixes #3216
  • Loading branch information
marstamm committed Nov 29, 2022
1 parent 533ae72 commit 8ecb65f
Show file tree
Hide file tree
Showing 3 changed files with 551 additions and 660 deletions.
4 changes: 2 additions & 2 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@bpmn-io/dmn-migrate": "^0.4.3",
"@bpmn-io/extract-process-variables": "^0.6.0",
"@bpmn-io/form-js": "^0.9.9",
"@bpmn-io/properties-panel": "^0.24.0",
"@bpmn-io/properties-panel": "^1.0.1",
"@bpmn-io/replace-ids": "^0.2.0",
"@camunda/execution-platform": "^0.3.2",
"@camunda/form-linting": "^0.1.2",
Expand All @@ -26,7 +26,7 @@
"@ibm/plex": "^6.0.0",
"@sentry/browser": "^6.3.6",
"bpmn-js": "^10.2.1",
"bpmn-js-properties-panel": "^1.11.2",

This comment has been minimized.

Copy link
@nikku

nikku Nov 30, 2022

Member

@marstamm Let's always bump dependencies in a dedicated DEPS commit. I had to git blame to find this one.

This comment has been minimized.

Copy link
@nikku

nikku Nov 30, 2022

Member

We'll otherwise run into stuff like this: #3029 (comment).

This comment has been minimized.

Copy link
@nikku

nikku Nov 30, 2022

Member

(Feels awkward to not be able to have a dedicated commit to quote).

This comment has been minimized.

Copy link
@marstamm

marstamm Nov 30, 2022

Author Member

Thanks for highlighting it, I will keep this in mind 🙂

"bpmn-js-properties-panel": "^1.12.0",
"bpmn-moddle": "^8.0.0",
"camunda-bpmn-js": "^0.21.1",
"camunda-bpmn-moddle": "^7.0.1",
Expand Down
3 changes: 3 additions & 0 deletions client/src/app/tabs/cloud-bpmn/BpmnEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,9 @@ export class BpmnEditor extends CachedComponent {
changeTemplateCommand: 'propertiesPanel.zeebe.changeTemplate',
linting: {
active: layout.panel && layout.panel.open && layout.panel.tab === 'linting'
},
propertiesPanel: {
feelTooltipContainer: '.editor'
}
});

Expand Down
Loading

0 comments on commit 8ecb65f

Please sign in to comment.